Fully Deprecate Helm Push #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljguarino
force-pushed
the
deprecate-helm-push-plugin
branch
from
1d74a3b to
9ada9d4
Compare
This provides a reimplementation of helm push's functionality straight into the plural cli, allowing us to both upload and download charts without direct helm or helm plugin interaction.
michaeljguarino
force-pushed
the
deprecate-helm-push-plugin
branch
from
9ada9d4 to
e593a06
Compare
davidspek
approved these changes
May 9, 2022
|
We should probably remove the helm-push installation from the Brew tap, see https://github.com/pluralsh/plural-cli/blob/master/.goreleaser.yaml#L109. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This provides a reimplementation of helm push's functionality straight into the plural cli, allowing us to both upload and download charts without direct helm or helm plugin interaction.
Test Plan
Locally updated deps and push a new helm version
Checklist
Closes #12