chore(frontend): update dependency vite to v4.5.3 [security] #1280

plural-renovate · 2023-12-06T01:45:20Z

This PR contains the following updates:

Package	Type	Update	Change
vite (source)	devDependencies	patch	`4.5.0` -> `4.5.3`

GitHub Vulnerability Alerts

CVE-2023-49293

Summary

When Vite's HTML transformation is invoked manually via server.transformIndexHtml, the original request URL is passed in unmodified, and the html being transformed contains inline module scripts (<script type="module">...</script>), it is possible to inject arbitrary HTML into the transformed output by supplying a malicious URL query string to server.transformIndexHtml.

Impact

Only apps using appType: 'custom' and using the default Vite HTML middleware are affected. The HTML entry must also contain an inline script. The attack requires a user to click on a malicious URL while running the dev server. Restricted files aren't exposed to the attacker.

Patches

Fixed in vite@5.0.5, vite@4.5.1, vite@4.4.12

Details

Suppose index.html contains an inline module script:

<script type="module">
  // Inline script
</script>

This script is transformed into a proxy script like

<script type="module" src="/index.html?html-proxy&index=0.js"></script>

due to Vite's HTML plugin:

https://github.com/vitejs/vite/blob/7fd7c6cebfcad34ae7021ebee28f97b1f28ef3f3/packages/vite/src/node/plugins/html.ts#L429-L465

When appType: 'spa' | 'mpa', Vite serves HTML itself, and htmlFallbackMiddleware rewrites req.url to the canonical path of index.html,

https://github.com/vitejs/vite/blob/73ef074b80fa7252e0c46a37a2c94ba8cba46504/packages/vite/src/node/server/middlewares/htmlFallback.ts#L44-L47

so the url passed to server.transformIndexHtml is /index.html.

However, if appType: 'custom', HTML is served manually, and if server.transformIndexHtml is called with the unmodified request URL (as the SSR docs suggest), then the path of the transformed html-proxy script varies with the request URL. For example, a request with path / produces

<script type="module" src="/@&#8203;id/__x00__/index.html?html-proxy&index=0.js"></script>

It is possible to abuse this behavior by crafting a request URL to contain a malicious payload like

"></script><script>alert('boom')</script>

so a request to http://localhost:5173/?%22%3E%3C/script%3E%3Cscript%3Ealert(%27boom%27)%3C/script%3E produces HTML output like

<script type="module" src="/@&#8203;id/__x00__/?"></script><script>alert("boom")</script>?html-proxy&index=0.js"></script>

which demonstrates XSS.

PoC

Example 1. Serving HTML from vite dev middleware with appType: 'custom'
- Go to https://stackblitz.com/edit/vitejs-vite-9xhma4?file=main.js&terminal=dev-html
- "Open in New Tab"
- Edit URL to set query string to ?%22%3E%3C/script%3E%3Cscript%3Ealert(%27boom%27)%3C/script%3E and navigate
- Witness XSS:
Example 2. Serving HTML from SSR-style Express server (Vite dev server runs in middleware mode):
- Go to https://stackblitz.com/edit/vitejs-vite-9xhma4?file=main.js&terminal=server
- (Same steps as above)
Example 3. Plain vite dev (this shows that vanilla vite dev is not vulnerable, provided htmlFallbackMiddleware is used)
- Go to https://stackblitz.com/edit/vitejs-vite-9xhma4?file=main.js&terminal=dev
- (Same steps as above)
- You should not see the alert box in this case

Detailed Impact

This will probably predominantly affect development-mode SSR, where vite.transformHtml is called using the original req.url, per the docs:

https://github.com/vitejs/vite/blob/7fd7c6cebfcad34ae7021ebee28f97b1f28ef3f3/docs/guide/ssr.md?plain=1#L114-L126

However, since this vulnerability affects server.transformIndexHtml, the scope of impact may be higher to also include other ad-hoc calls to server.transformIndexHtml from outside of Vite's own codebase.

My best guess at bisecting which versions are vulnerable involves the following test script

import fs from 'node:fs/promises';
import * as vite from 'vite';

const html = `
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
  </head>
  <body>
    <script type="module">
      // Inline script
    </script>
  </body>
</html>
`;
const server = await vite.createServer({ appType: 'custom' });
const transformed = await server.transformIndexHtml('/?%22%3E%3C/script%3E%3Cscript%3Ealert(%27boom%27)%3C/script%3E', html);
console.log(transformed);
await server.close();

and using it I was able to narrow down to #13581. If this is correct, then vulnerable Vite versions are 4.4.0-beta.2 and higher (which includes 4.4.0).

CVE-2024-23331

Summary

Vite dev server option server.fs.deny can be bypassed on case-insensitive file systems using case-augmented versions of filenames. Notably this affects servers hosted on Windows.

This bypass is similar to https://nvd.nist.gov/vuln/detail/CVE-2023-34092 -- with surface area reduced to hosts having case-insensitive filesystems.

Patches

Fixed in vite@5.0.12, vite@4.5.2, vite@3.2.8, vite@2.9.17

Details

Since picomatch defaults to case-sensitive glob matching, but the file server doesn't discriminate; a blacklist bypass is possible.

See picomatch usage, where nocase is defaulted to false: https://github.com/vitejs/vite/blob/v5.1.0-beta.1/packages/vite/src/node/server/index.ts#L632

By requesting raw filesystem paths using augmented casing, the matcher derived from config.server.fs.deny fails to block access to sensitive files.

PoC

Setup

Created vanilla Vite project using npm create vite@latest on a Standard Azure hosted Windows 10 instance.
- npm run dev -- --host 0.0.0.0
- Publicly accessible for the time being here: http://20.12.242.81:5173/
Created dummy secret files, e.g. custom.secret and production.pem
Populated vite.config.js with

export default { server: { fs: { deny: ['.env', '.env.*', '*.{crt,pem}', 'custom.secret'] } } }

Reproduction

curl -s http://20.12.242.81:5173/@fs//
- Descriptive error page reveals absolute filesystem path to project root
curl -s http://20.12.242.81:5173/@fs/C:/Users/darbonzo/Desktop/vite-project/vite.config.js
- Discoverable configuration file reveals locations of secrets
curl -s http://20.12.242.81:5173/@fs/C:/Users/darbonzo/Desktop/vite-project/custom.sEcReT
- Secrets are directly accessible using case-augmented version of filename

Proof

Impact

Who

Users with exposed dev servers on environments with case-insensitive filesystems

What

Files protected by server.fs.deny are both discoverable, and accessible

CVE-2024-31207

Summary

Vite dev server option server.fs.deny did not deny requests for patterns with directories. An example of such a pattern is /foo/**/*.

Impact

Only apps setting a custom server.fs.deny that includes a pattern with directories, and explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected.

Patches

Fixed in vite@5.2.6, vite@5.1.7, vite@5.0.13, vite@4.5.3, vite@3.2.10, vite@2.9.18

Details

server.fs.deny uses picomatch with the config of { matchBase: true }. matchBase only matches the basename of the file, not the path due to a bug (https://github.com/micromatch/picomatch/issues/89). The vite config docs read like you should be able to set fs.deny to glob with picomatch. Vite also does not set { dot: true } and that causes dotfiles not to be denied unless they are explicitly defined.

Reproduction

Set fs.deny to ['**/.git/**'] and then curl for /.git/config.

with matchBase: true, you can get any file under .git/ (config, HEAD, etc).
with matchBase: false, you cannot get any file under .git/ (config, HEAD, etc).

Release Notes

vitejs/vite (vite)

`v4.5.3`

Compare Source

Please refer to CHANGELOG.md for details.

`v4.5.2`

Compare Source

Please refer to CHANGELOG.md for details.

`v4.5.1`

Compare Source

Please refer to CHANGELOG.md for details.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

plural-renovate · 2024-03-01T14:38:05Z

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: www/yarn.lock

/usr/local/bin/yarn: line 4: .: filename argument required
.: usage: . filename [arguments]
/opt/containerbase/tools/corepack/0.28.2/node_modules/corepack/dist/lib/corepack.cjs:23025
  const isURL = URL.canParse(range);
                    ^

TypeError: URL.canParse is not a function
    at parseSpec (/opt/containerbase/tools/corepack/0.28.2/node_modules/corepack/dist/lib/corepack.cjs:23025:21)
    at loadSpec (/opt/containerbase/tools/corepack/0.28.2/node_modules/corepack/dist/lib/corepack.cjs:23088:11)
    at async Engine.findProjectSpec (/opt/containerbase/tools/corepack/0.28.2/node_modules/corepack/dist/lib/corepack.cjs:23262:22)
    at async Engine.executePackageManagerRequest (/opt/containerbase/tools/corepack/0.28.2/node_modules/corepack/dist/lib/corepack.cjs:23314:24)
    at async Object.runMain (/opt/containerbase/tools/corepack/0.28.2/node_modules/corepack/dist/lib/corepack.cjs:24007:5)

Node.js v18.16.0

plural-renovate bot requested a review from a team as a code owner December 6, 2023 01:45

plural-renovate bot added dependencies Pull requests that update a dependency file frontend Changes related to the frontend labels Dec 6, 2023

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch 2 times, most recently from a1fc683 to 692cfb9 Compare December 18, 2023 22:23

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch 8 times, most recently from d64ea47 to 154d194 Compare January 5, 2024 23:40

plural-renovate bot changed the title ~~chore(frontend): update dependency vite to v4.4.12 [security]~~ chore(frontend): update dependency vite to v4.5.1 [security] Jan 5, 2024

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch from 154d194 to 549772a Compare January 20, 2024 04:59

plural-renovate bot changed the title ~~chore(frontend): update dependency vite to v4.5.1 [security]~~ chore(frontend): update dependency vite to v4.5.2 [security] Jan 20, 2024

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch 2 times, most recently from a74259a to b5a81c8 Compare March 7, 2024 17:14

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch from b5a81c8 to 36e38f9 Compare April 4, 2024 03:40

plural-renovate bot changed the title ~~chore(frontend): update dependency vite to v4.5.2 [security]~~ chore(frontend): update dependency vite to v4.5.3 [security] Apr 4, 2024

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch 2 times, most recently from 948d50d to 355997a Compare May 7, 2024 21:43

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch from 355997a to 9fd93bb Compare May 10, 2024 23:05

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch from 9fd93bb to 1d25afd Compare June 5, 2024 16:51

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch 4 times, most recently from 6f521d8 to 46f1b84 Compare June 24, 2024 22:11

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch from 46f1b84 to 3009700 Compare July 3, 2024 15:40

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch from 3009700 to 9f9f1c3 Compare July 3, 2024 16:01

chore(frontend): update dependency vite to v4.5.3 [security]

0d631aa

plural-renovate bot force-pushed the renovate/frontend/npm-vite-vulnerability branch from 9f9f1c3 to 0d631aa Compare July 4, 2024 00:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(frontend): update dependency vite to v4.5.3 [security] #1280

chore(frontend): update dependency vite to v4.5.3 [security] #1280

plural-renovate bot commented Dec 6, 2023 •

edited

Loading

plural-renovate bot commented Mar 1, 2024 •

edited

Loading

chore(frontend): update dependency vite to v4.5.3 [security] #1280

Are you sure you want to change the base?

chore(frontend): update dependency vite to v4.5.3 [security] #1280

Conversation

plural-renovate bot commented Dec 6, 2023 • edited Loading

GitHub Vulnerability Alerts

CVE-2023-49293

Summary

Impact

Patches

Details

PoC

Detailed Impact

CVE-2024-23331

Summary

Patches

Details

PoC

Impact

CVE-2024-31207

Summary

Impact

Patches

Details

Release Notes

v4.5.3

v4.5.2

v4.5.1

Configuration

plural-renovate bot commented Mar 1, 2024 • edited Loading

⚠ Artifact update problem

File name: www/yarn.lock

plural-renovate bot commented Dec 6, 2023 •

edited

Loading

`v4.5.3`

`v4.5.2`

`v4.5.1`

plural-renovate bot commented Mar 1, 2024 •

edited

Loading