Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot invoke "net.minecraft.class_239.method_17783()" because "trace" is null #101

Closed
1 task done
Earthcomputer opened this issue Aug 26, 2023 · 1 comment
Closed
1 task done
Labels
type: bug Something isn't working

Comments

@Earthcomputer
Copy link

Minecraft Version

1.20.1

MasaGadget Version

3.2.318 67ab5b4-stable

Description

Crash happens commonly when logging in with 1.20.1 with tweakeroo.

Tweakeroo's RayTraceUtils.getRayTraceFromEntity is marked @Nonnull. RenderUtils uses this method to get trace, but MasaGadgets redirects this to a cached version, which is nullable. This caused the crash.

Possible fix is to use BlockHitResult.createMissed(Vec3d.ZERO, Direction.UP, BlockPos.ORIGIN); instead of null, which is what RayTraceUtils.getRayTraceFromEntity uses for misses.

To Reproduce

Not sure exactly, it seems to happen commonly though

Expected behavior

No crash

Log

https://mclo.gs/KMDPIk7

Latest CI build tested

  • I confirm that this problem still exists with the latest CI build.
@Earthcomputer Earthcomputer added the type: bug Something isn't working label Aug 26, 2023
Hendrix-Shen added a commit that referenced this issue Aug 27, 2023
Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
@Hendrix-Shen
Copy link
Collaborator

Fix in 877ab5b should be worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants