Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mail log if exception is thrown #58

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

sypets
Copy link
Contributor

@sypets sypets commented Aug 17, 2024

Resolves: #57


  1. Catch exception on send() and update tx_maillogger_domain_model_maillog
  2. In case of exception write $->getMessage() to tx_maillogger_domain_model_maillog
  3. Mark logs with error in "Mail Logger" list view by using an icon
  4. Instead of showing "Accepted recipients: 1", name the field "Result" and show error message, if error message exists
  5. add extra field "status" with numeric value

This might still benefit from fine tuning:

  • make it pretty
  • localize some more texts

Example output:

list:

image

detail:

image

@sypets sypets force-pushed the update-log-if-exception branch 2 times, most recently from 10c3d94 to 96ecd46 Compare August 17, 2024 17:24
@Kanti Kanti force-pushed the update-log-if-exception branch 3 times, most recently from 6f3e450 to d025994 Compare August 19, 2024 09:37
@Kanti Kanti merged commit 7a275d1 into pluswerk:master Aug 19, 2024
7 checks passed
@Kanti
Copy link
Member

Kanti commented Aug 19, 2024

@sypets Thank you so much for the awesome enhancement! I've made a few small adjustments and just released it in version 4.1.0.

@sypets
Copy link
Contributor Author

sypets commented Aug 24, 2024

@Kanti Thank you so much. I have been on holiday, will take a look next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error send status of email is not shown in log if an exception is thrown during send
2 participants