Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft with webhook support #25

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

krishnateja262
Copy link
Contributor

@plutov raising a draft PR, let me know if this is ok or any changes that are required. Working on UI changes and timeout setting.

Copy link

vercel bot commented Sep 30, 2024

@krishnateja262 is attempting to deploy a commit to the formulosity Team on Vercel.

A member of the Team first needs to authorize it.

@plutov
Copy link
Owner

plutov commented Oct 5, 2024

Hi @krishnateja262 yes the format is good. The yam configuration is enough for now, so we just need to make it work:

  • Send the webhook with data as JSON
  • With some default timeout
  • Probably in a goroutine
  • Record the response status together with response object
  • Show it on Responses tab

@plutov
Copy link
Owner

plutov commented Oct 11, 2024

Hi @krishnateja262 how are things going with this PR? do you need help maybe?

@krishnateja262
Copy link
Contributor Author

Hi @plutov, sorry got occupied with work, pushed few more changes, for this PR i created a table for storing webhook responses and status codes
when running the application in docker the new table is not getting created getting this error
no such table: surveys_webhook_responses

@plutov
Copy link
Owner

plutov commented Oct 12, 2024

Hi @krishnateja262 I see that you've added the CREATE TABLE into the existing migration, it's better to add to a new one. Because once the migration is executed once it won't be executed anymore, that's how migrations work.

@krishnateja262 krishnateja262 marked this pull request as ready for review October 13, 2024 16:44
@krishnateja262
Copy link
Contributor Author

Hi @plutov i have made the changes, attaching screenshot for the UI change, please review and let me know for any changes. The downloaded file also has the webhook data

Screenshot 2024-10-13 at 10 14 19 PM

@plutov
Copy link
Owner

plutov commented Oct 16, 2024

This is awesome @krishnateja262 will test it in the next few days and probably merge it!

@plutov
Copy link
Owner

plutov commented Oct 16, 2024

it works well, I am merging it!

@plutov plutov merged commit b84276e into plutov:main Oct 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants