Enhance Application.get_channel and Application.get_connection
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh if the process is not alive.
ono
requested changes
Mar 1, 2022
mix.exs
Outdated
| @@ -2,7 +2,7 @@ defmodule AMQP.Mixfile do | |||
| use Mix.Project | |||
|
|
|||
| @source_url "https://github.com/pma/amqp" | |||
| @version "3.1.0" | |||
| @version "3.1.1" | |||
There was a problem hiding this comment.
remove the versioning bump from PR
lib/amqp/application/connection.ex
Outdated
Comment on lines
96
to
100
| with false <- whereis(name) |> is_nil(), | ||
| conn <- GenServer.call(get_server_name(name), :get_connection) do | ||
| if conn |> is_nil(), do: {:error, :not_connected}, else: {:ok, conn} | ||
| else | ||
| true -> {:error, :connection_not_found} |
There was a problem hiding this comment.
Suggested change
| with false <- whereis(name) |> is_nil(), | |
| conn <- GenServer.call(get_server_name(name), :get_connection) do | |
| if conn |> is_nil(), do: {:error, :not_connected}, else: {:ok, conn} | |
| else | |
| true -> {:error, :connection_not_found} | |
| server_name = get_server_name(name) | |
| with false <- server_name |> whereis() |> is_nil(), | |
| conn = %{} <- GenServer.call(server_name, :get_connection)} do | |
| {:ok, conn} | |
| else | |
| true -> {:error, :connection_not_found} | |
| nil -> {:error, :not_connected} |
There was a problem hiding this comment.
whereis/1 function is already there in the module.:
def whereis(name) do
name
|> get_server_name()
|> GenServer.whereis()
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application.get_channelandApplication.get_connectionno longer crash if the name of the process given is not alive.