-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduction to one callback (All pairs) #40
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After long trial and error I found a way to reduce callback and requests to server to 1 regardless of pair amount. It also reduces Package Amount to 16 Kb (avg. 4kb per Pair) to before 5Kb per pair. Includes pmaji#39
This was referenced Feb 18, 2018
Closed
If Graph is already hidden text was wrong.
Feature is clompletly tested and should work without any problems |
Added correct caching for prepared html data, to reduce load on server. Now every request just gets the cached data -> no further computation in callback
Data gets pasted with first update anyways. So no need to have duplicate code and empty graphs at beginning
Added reduced inital load. |
Closed
Combined with #37 Load reduced to 5.3 Kb for 8 pairs. Before changes we had 5.8Kb per Pair 👍 |
Closed
Would be interesting to see, if problem described in #16 is solved by this. |
theimo1221
added a commit
to theimo1221/eth_python_tracker
that referenced
this pull request
Feb 18, 2018
Closed cause of #41 was approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After long trial and error I found a way to reduce callback and requests to server to 1 regardless of pair amount.
It also reduces Package Amount to 16 Kb (avg. 4kb per Pair) to before 5Kb per pair.
Includes #39