Skip to content

Comments

Fix shared_tasks.toml check sequence referencing undefined tasks#14

Merged
pmalarme merged 2 commits intofeature/add-documentation-and-copilot-instructionsfrom
copilot/sub-pr-9-another-one
Feb 17, 2026
Merged

Fix shared_tasks.toml check sequence referencing undefined tasks#14
pmalarme merged 2 commits intofeature/add-documentation-and-copilot-instructionsfrom
copilot/sub-pr-9-another-one

Conversation

Copy link
Contributor

Copilot AI commented Feb 17, 2026

Summary

The shared check sequence in shared_tasks.toml referenced mypy, bandit, and test tasks that weren't defined, breaking poe check for agents without their own implementations.

Added default task definitions:

  • mypy: Type-checks src/ using agent's config
  • bandit: Security-scans src/ and docs/source/
  • test: Runs pytest with coverage

Agents can override these defaults in their pyproject.toml for custom paths/options (as agent1 already does).

Testing

  • uv run poe check
  • Code review and CodeQL security scan passed

Checklist

  • Linked issue or task reference
  • Added/updated tests where relevant
  • Updated docs/README if needed
  • No secrets or sensitive data added
  • Considered backward compatibility and deployment impact

Additional context

Maintains existing behavior for agent1 (which overrides all three tasks) while making shared_tasks.toml self-consistent for future agents.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pmalarme <686568+pmalarme@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on adding documentation and copilot instructions Fix shared_tasks.toml check sequence referencing undefined tasks Feb 17, 2026
Copilot AI requested a review from pmalarme February 17, 2026 14:24
@pmalarme pmalarme marked this pull request as ready for review February 17, 2026 14:35
Copilot AI review requested due to automatic review settings February 17, 2026 14:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical issue in shared_tasks.toml where the check sequence referenced three tasks (mypy, bandit, test) that weren't defined, causing poe check to fail for agents without their own implementations.

Changes:

  • Added default task definitions for mypy, bandit, and test in shared_tasks.toml
  • Added explanatory comment noting agents can override these defaults in their pyproject.toml
  • Ensures shared_tasks.toml is self-consistent and works standalone

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pmalarme pmalarme merged commit 6fafd73 into feature/add-documentation-and-copilot-instructions Feb 17, 2026
6 checks passed
@pmalarme pmalarme deleted the copilot/sub-pr-9-another-one branch February 17, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants