Validate agent names before Docker build in python-docker-build workflow#43
Merged
pmalarme merged 2 commits intofeature/add-documentation-and-copilot-instructionsfrom Feb 19, 2026
Conversation
8 tasks
Co-authored-by: pmalarme <686568+pmalarme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on documentation and copilot instructions
Validate agent names before Docker build in python-docker-build workflow
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent names extracted from
git diffoutput viacut -d/ -f2were flowing unvalidated into Docker build arguments (-t,-f, path). Onpull_requesttriggers from forks, a contributor could craft a directory name with characters invalid in Docker image tags or that confuse shell tooling (spaces, colons, uppercase, etc.).Added an allowlist regex check in the
detectjob's agent-discovery loop:Names not matching
^[a-z0-9][a-z0-9_-]*$are skipped with a workflow warning rather than passed todocker build.Testing
uv run poe checkChecklist
Additional context
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.