Increase test coverage threshold to 100% for security-sensitive validators#94
Draft
Increase test coverage threshold to 100% for security-sensitive validators#94
Conversation
- Add [tool.coverage.report] fail_under = 100 to agents/agent1/pyproject.toml so coverage.py enforces 100% regardless of how tests are invoked - Add test-validators Poe task scoped to validators subpackage with --cov-fail-under=100, as a separate pytest-cov run per the issue suggestion - Update agent1 check sequence to include test-validators Co-authored-by: pmalarme <686568+pmalarme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Raise test coverage threshold for security-sensitive validators
Increase test coverage threshold to 100% for security-sensitive validators
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global 80% coverage threshold in the root
pyproject.tomlis insufficient for security-sensitivevalidators/modules where edge cases (None, empty strings, whitespace, non-string types) are security boundaries.Changes
agents/agent1/pyproject.toml[tool.coverage.report] fail_under = 100— enforces 100% at the coverage.py level independent of pytest invocation flagstest-validatorsPoe task: a dedicated pytest-cov run scoped topython_agent_template.agents.agent1.validatorswith--cov-fail-under=100, per the issue's "separate scoped run" suggestion; runs all tests (not filtered to a single file) to automatically cover future validator additionschecksequence to includetest-validators, so the validators-specific threshold is part of every quality gate runTesting
uv run poe checkuv run poe -C agents/agent1 testanduv run poe -C agents/agent1 test-validators— both report 100% coverageChecklist
Additional context
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.