fix XML spec whitespace compliance #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ease CDATA processing, TBXML used to use a trick where after moving the actual content 'over' the start of the CDATA section, the remaning characters to the right are been overwritten with whitespace. Lateron, TBXML cleans all the whitespace within(!) the text content, thus removing the whitespace it added in the first step. However, removing significant whitespace (enclosed within the text portion of a tag) is against the spec. It's unfortunately not enough to remove said portions of code, but you also need to catch up with the CDATA trick. My approach is to indicate the end of the text with a \0 marker and setting the elementStart appropriately to continue searching. As a neat side-effect, this also slightly improves the parsing speed.
|
Thanks for your comment. In order to fix another oddity, I had to patch the computation of the elementStart to something more simple – I believe this also fixes your issue with multiple CDATA sections back-to-back. I will run a test asap. |
Unfortunately some servers still send ascii, macosroman, or similar encodings – in such cases, TBXML parses null instead of the right strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ease CDATA processing, TBXML used to use a trick where after
moving the actual content 'over' the start of the CDATA section,
the remaning characters to the right are been overwritten with whitespace.
Lateron, TBXML cleans all the whitespace within(!) the text content,
thus removing the whitespace it added in the first step.
However, removing significant whitespace (enclosed within the text
portion of a tag) is against the spec. It's unfortunately not enough
to remove said portions of code, but you also need to catch up with the
CDATA trick. My approach is to indicate the end of the text with a \0
marker and setting the elementStart appropriately to continue searching.
As a neat side-effect, this also slightly improves the parsing speed.