-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changeable nat64 prefix, and large-ish UX changes #59
Open
BPplays
wants to merge
110
commits into
pmarks-net:master
Choose a base branch
from
BPplays:v6_nat_parse
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+903
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting, but it seems to work fine.
…rom the formatting
…r, ending up with the windows size as something like 400 but the body size as something like 401. fixedish by adding check to only enable scrollbar is the diff is more then 2
…anges nat64 prefix when the changes are invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend
what this adds:
there is also no automatic nat64 prefix detection which is a feature some people seemed to want.
doing that in the extension itself seems like it would require pinging something like ipv4.google.com and,
you'd probably want caching,
there'd be a tradeoff between how often you check the nat64 prefix and how many network requests you make,
for something like a laptop or phone you might want to update every few hours but longer would be better for stationary devices
you could also try to use a separate program like Yomitan can (for a different purpose) to get the nat64 prefix from the OS.
UX
changes:
sans-serif
instead of defaulting toNoto Sans
andArial
, im not sure the reason that was done i think using the users selected font works better hereknown issues:
onmousedown is used is responsiveness for anything the user wouldn't want to cancel, like checking a checkbox or selection a radio button.
i've also tested on mobile and it works fine there.
also if you have any other ideas for onmousedown for checkboxes and radio buttons let me know, the current method is kinda janky, though i haven't had any issues with it so far.
misc
this changes the makefile make an unpacked chrome build, i didn't see any instructions for a development workflow so i just loaded the unpacked extension and then reloaded it when i changed something, i can remove it from the makefile if you want.