Fix logging (do not touch root logger) #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaupin
added a commit
that referenced
this pull request
Dec 13, 2015
Fix logging (do not touch root logger)
|
Thanks! The pdfrw library grew out of a personal program, so there may still be a few more warts like this hiding in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
logging.basicConfigset the root logger, which is problematic for a library: when importing from another place - typically an application - I don't want one of the dependencies/libraries to mess with my root logger.The proposed fix does exactly the same thing (setting logging level and formatter), except it only does so for the pdfrw logger.