Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action aborts with: Error: Cannot read property 'split' of undefined #127

Closed
rsoesemann opened this issue Sep 22, 2022 · 1 comment · Fixed by #133
Closed

Action aborts with: Error: Cannot read property 'split' of undefined #127

rsoesemann opened this issue Sep 22, 2022 · 1 comment · Fixed by #133
Labels
bug Something isn't working
Milestone

Comments

@rsoesemann
Copy link
Member

When I created a PR with an Apex change the PMD Github Action aborted with this

analyze
Cannot read property 'split' of undefined

Looks like it aborted after parsing the SARIF of the second issue. At least only one is displayed correctly

@adangel
Copy link
Member

adangel commented Sep 24, 2022

We call split here:

const lines = rule.fullDescription.text.split(/\n|\r\n/);

I think, this problem occurs if a rule has no description... the action should however not abort, if this is the case.

@adangel adangel added the bug Something isn't working label Sep 24, 2022
adangel added a commit to adangel/pmd-github-action that referenced this issue Sep 24, 2022
@adangel adangel added this to the next milestone Sep 24, 2022
adangel added a commit that referenced this issue Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants