Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relativize paths if Sarif report already contains URIs #266

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

adangel
Copy link
Member

@adangel adangel commented Mar 16, 2024

Since PMD 7.0.0-rc3, the Sarif report already contains file://-URIs. This caused, that we didn't properly relativize the paths in the report, so that the code annotations didn't appear anymore.

Fixes #249

@adangel adangel added this to the v2.0.0 milestone Mar 16, 2024
@adangel adangel changed the title Relative paths in Sarif if Sarif report already contains URIs Relativize paths if Sarif report already contains URIs Mar 16, 2024
@adangel adangel merged commit b7104b3 into pmd:main Mar 17, 2024
3 checks passed
@adangel adangel deleted the issue-249-relative-paths branch March 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotations are not shown in PR / commit
1 participant