Skip to content

Move validateValue call to make sure it is measured by latency tracker #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Move validateValue call to make sure it is measured by latency tracker #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cachelib/cachebench/cache/Cache-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,14 +460,17 @@ typename Cache<Allocator>::ItemHandle Cache<Allocator>::find(Key key,
// find from cache and wait for the result to be ready.
auto it = cache_->find(key, mode);
it.wait();

if (valueValidatingEnabled()) {
XDCHECK(!consistencyCheckEnabled());
validateValue(it);
}

return it;
};

if (!consistencyCheckEnabled()) {
auto it = findFn();
if (valueValidatingEnabled()) {
validateValue(it);
}
return it;
}

Expand Down