Skip to content

Fix slab release code #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix slab release code #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cachelib/allocator/CacheAllocator-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3168,15 +3168,14 @@ bool CacheAllocator<CacheTrait>::markMovingForSlabRelease(
// At first, we assume this item was already freed
bool itemFreed = true;
bool markedMoving = false;
TierId tid = 0;
const auto fn = [&markedMoving, &itemFreed, &tid, this /* TODO - necessary for getTierId */](void* memory) {
TierId tid = getTierId(alloc);
const auto fn = [&markedMoving, &itemFreed](void* memory) {
// Since this callback is executed, the item is not yet freed
itemFreed = false;
Item* item = static_cast<Item*>(memory);
if (item->markMoving()) {
markedMoving = true;
}
tid = getTierId(*item);
};

auto startTime = util::getCurrentTimeSec();
Expand Down