Extend cachbench with touch value #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main purpose of this patch is to better simulate workloads in cachebench. Setting touchValue to true allows to see performance impact of using different mediums for memory cache.
byrnedj
reviewed
Jun 15, 2022
|
Yes, this is rebased version of patch which is being reviewed by Meta. I would like to merge it once they merge the patch to upstream. After that, we should use "touchValue": true by default |
|
Right now, we have old version of the patch on our develop branch (validateValue) |
|
Already merged into upstream |
danielobiri
pushed a commit
to danielobiri/CacheLib
that referenced
this pull request
Oct 19, 2022
Summary: Pull Request resolved: facebook#85 Reviewed By: sathyaphoenix Differential Revision: D32806006 Pulled By: leozzx fbshipit-source-id: b973a5bd5a3e1b7a566efb6887de21c0f8f756c4
byrnedj
pushed a commit
to byrnedj/CacheLib
that referenced
this pull request
Jun 7, 2023
byrnedj
pushed a commit
to byrnedj/CacheLib
that referenced
this pull request
Jul 24, 2023
byrnedj
pushed a commit
to byrnedj/CacheLib
that referenced
this pull request
Mar 12, 2024
byrnedj
pushed a commit
to byrnedj/CacheLib
that referenced
this pull request
May 8, 2024
byrnedj
pushed a commit
to byrnedj/CacheLib
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this patch is to better simulate workloads in
cachebench. Setting touchValue to true allows to see performance
impact of using different mediums for memory cache.
This change is