Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge volatile module, store persistent and volatile module in root dir #349

Merged
merged 16 commits into from
Oct 27, 2022

Conversation

JiayuZzz
Copy link
Collaborator

What is changed and how it works?

Cherry-pick volatile branch, store persistent and volatile module to independent directories.

Check List

Tests

  • Unit test
  • Stress test

Side effects

No

Signed-off-by: Jiayu Wu <jiayu.wu@intel.com>
Signed-off-by: Jiayu Wu <jiayu.wu@intel.com>
Signed-off-by: Jiayu Wu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
Copy link
Contributor

@iyupeng iyupeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 questions:

  • Will we use different namespaces for persistent and volatile, in the future? Otherwise, these 2 modules may not be compiled into one app.

  • Also, will there be some common parts being extracted from both modules, e.g., header files?

@JiayuZzz
Copy link
Collaborator Author

JiayuZzz commented Oct 25, 2022

Just 2 questions:

  • Will we use different namespaces for persistent and volatile, in the future? Otherwise, these 2 modules may not be compiled into one app.
  • Also, will there be some common parts being extracted from both modules, e.g., header files?
  1. Yes, this is a todo task. Also, as c API can't be isolated by namespace, we may need to do some rename work.
  2. Yes, like Status and common types.

Signed-off-by: Wu, Jiayu <jiayu.wu@intel.com>
@JiayuZzz JiayuZzz merged commit e3bbe95 into pmem:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants