Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: new argument to match script #1658

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Conversation

GBuella
Copy link
Contributor

@GBuella GBuella commented Feb 6, 2017

(Keeping the script in sync with other projects using the same script)

The output log and the match file don't have
to be in the same directory.
This helps while using the match script in
out of source builds. E.g.:

$(SRC)/match -o $(BUILD)/output_log $(SRC)/matchfile


This change is Reviewable

(Keeping the script in sync with other projects using the same script)

The output log and the match file don't have
to be in the same directory.
This helps while using the match script in
out of source builds. E.g.:

$(SRC)/match -o $(BUILD)/output_log $(SRC)/matchfile
@tomaszkapela
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@krzycz
Copy link
Contributor

krzycz commented Feb 6, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@krzycz
Copy link
Contributor

krzycz commented Feb 7, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


src/test/match, line 64 at r1 (raw file):

#		directory and match them again the corresponding file "X".
#
#	-o	custom output filename - only one match file can be given

Good idea!
But, what if this new option allows to provide an output directory, not just a single output file? Then, you could run match script in the same way as we do it now - find all the match files in the current/test directory and match them against the corresponding files in the output directory? IOW, if -o is not specified, then output dir == current dir.


Comments from Reviewable

@GBuella
Copy link
Contributor Author

GBuella commented Feb 7, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


src/test/match, line 64 at r1 (raw file):

Previously, krzycz (Krzysztof Czurylo) wrote…

Good idea!
But, what if this new option allows to provide an output directory, not just a single output file? Then, you could run match script in the same way as we do it now - find all the match files in the current/test directory and match them against the corresponding files in the output directory? IOW, if -o is not specified, then output dir == current dir.

Maybe later, the current direct goal to be able to do out of source builds. Once everything works well, we can start adding such featureoids.


Comments from Reviewable

@plebioda
Copy link
Contributor

plebioda commented Feb 7, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


Comments from Reviewable

@krzycz krzycz merged commit c43374b into pmem:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants