common: move on to the new coverage uploader #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszstolarczuk
force-pushed
the
change-codecov-uploader
branch
2 times, most recently
from
f1e148d
to
bd05f70
Compare
lukaszstolarczuk
force-pushed
the
change-codecov-uploader
branch
3 times, most recently
from
e203387
to
b72fc75
Compare
ldorau
added a commit
to ldorau/rpma
that referenced
this pull request
Mar 14, 2023
Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548
ldorau
added a commit
to ldorau/rpma
that referenced
this pull request
Mar 14, 2023
Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548
ldorau
added a commit
to ldorau/rpma
that referenced
this pull request
Mar 14, 2023
Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548
ldorau
added a commit
to ldorau/rpma
that referenced
this pull request
Mar 15, 2023
Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548
|
codecov/project Failing after 1s — 67.99% (-3.28%) compared to 9b201f7 |
ldorau
added a commit
to ldorau/rpma
that referenced
this pull request
Mar 15, 2023
Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548
ldorau
added a commit
to ldorau/rpma
that referenced
this pull request
Mar 16, 2023
Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548
lukaszstolarczuk
force-pushed
the
change-codecov-uploader
branch
from
b72fc75
to
c44fd99
Compare
the old, bash uploader is long EOL now. Downloading and integrity check of the uploader script is done in docker building process (on the latest Ubuntu LTS).
lukaszstolarczuk
force-pushed
the
change-codecov-uploader
branch
from
c44fd99
to
8fc45ab
Compare
|
Now, I believe this PR is ready for merging. The report is available here: Coverage is high enough: 74.26% We cannot compare file-by-file because (for some reason) the previous push to master (BASE 35ca902) is missing a codecov report. Looking at the CI logs it looks ok to me. If anything comes up later on, it will be fixed in a separate PR. |
ldorau
added a commit
to ldorau/rpma
that referenced
this pull request
Apr 14, 2023
Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548
ldorau
added a commit
to ldorau/rpma
that referenced
this pull request
Apr 14, 2023
Move on to the new coverage uploader. The old bash uploader is long EOL now. See: pmem/pmdk#5548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old, bash uploader is long EOL now.
Downloading and integrity check of the uploader script is done in docker building process (on the latest Ubuntu LTS).
Fixes: #5373
// Partially based on our previous work in pmemstream:
pmem/pmemstream@f82a9d1
// Documentation for the codecov uploader:
https://docs.codecov.com/docs/codecov-uploader
// If we ever resign from running coverage check on Travis, we could make use of GitHub's Action:
https://about.codecov.io/blog/how-to-set-up-codecov-with-c-and-github-actions/
This change is