Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable test until #5599 fixed #5653

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 17, 2023

Disable the test until #5599 is fixed.

Signed-off-by: Tomasz Gromadzki tomasz.gromadzki@intel.com


This change is Reviewable

@grom72 grom72 added this to the 1.13 on GHA milestone May 17, 2023
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


src/test/pmem2_map_prot/TESTS.py line 3 at r1 (raw file):

#!../env.py
# SPDX-License-Identifier: BSD-3-Clause
# Copyright 2020, Intel Corporation

Copyright 2020-2023, Intel Corporation

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)


src/test/pmem2_map_prot/TESTS.py line 75 at r1 (raw file):

XXX disable the test until URL is fixed.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 marked this pull request as ready for review May 17, 2023 12:01
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)


src/test/pmem2_map_prot/TESTS.py line 3 at r1 (raw file):

Previously, osalyk (Oksana Sałyk) wrote…

Copyright 2020-2023, Intel Corporation

Done.


src/test/pmem2_map_prot/TESTS.py line 75 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

XXX disable the test until URL is fixed.

Done.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #5653 (046e458) into stable-1.13 (1719502) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           stable-1.13    #5653   +/-   ##
============================================
  Coverage        74.25%   74.26%           
============================================
  Files              145      145           
  Lines            22131    22131           
  Branches          3704     3705    +1     
============================================
+ Hits             16433    16435    +2     
+ Misses            5698     5696    -2     

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 merged commit bfab2cc into pmem:stable-1.13 May 17, 2023
@grom72 grom72 deleted the test-fix-5599 branch May 17, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants