Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable avx512f tests (pmem2_mem_ext) under Valgrind #5658

Merged
merged 3 commits into from
May 19, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 18, 2023

Disable avx512f tests (pmem2_mem_ext) until Valigrind will provide support for avx512f instruction.

See: #5640


This change is Reviewable

Disable avx512f tests until Valgrind until
Valigrind will provide support for avx512f instruction.

See: pmem#5640

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 added this to the 1.13 on GHA milestone May 18, 2023
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


src/test/pmem2_mem_ext/TESTS.py line 119 at r2 (raw file):

# All tests with variant VARIANT_AVX512F are disabled under Valgrind
# until the issue https://github.com/pmem/pmdk/issues/5640 is fixed.

Unorthodox comment indentation.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #5658 (f1ffe19) into stable-1.13 (850a099) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           stable-1.13    #5658      +/-   ##
===============================================
- Coverage        74.27%   74.26%   -0.01%     
===============================================
  Files              145      145              
  Lines            22131    22131              
  Branches          3705     3705              
===============================================
- Hits             16438    16436       -2     
- Misses            5693     5695       +2     

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)


src/test/pmem2_mem_ext/TESTS.py line 119 at r2 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Unorthodox comment indentation.

Done.

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit d127b14 into pmem:stable-1.13 May 19, 2023
@grom72 grom72 deleted the test-fix-5640 branch May 25, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants