Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable ex_libpmem2/TEST6 for 'helgrind' until #5638 is fixed #5669

Merged
merged 2 commits into from
May 22, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 22, 2023

test: disable ex_libpmem2/TEST6 for 'helgrind' until #5638 is fixed

Requires:


This change is Reviewable

@grom72 grom72 added this to the 1.13 on GHA milestone May 22, 2023
@t.require_valgrind_disabled() can only be used one time
as a class decorator.

This fix improves the fix pmem#5664

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Disable ex_libpmem2/TEST6 for 'helgrind'
until the issue pmem#5638 is fixed.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #5669 (72c2b5e) into stable-1.13 (83975ef) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           stable-1.13    #5669   +/-   ##
============================================
  Coverage        74.27%   74.28%           
============================================
  Files              145      145           
  Lines            22131    22131           
  Branches          3704     3705    +1     
============================================
+ Hits             16437    16439    +2     
+ Misses            5694     5692    -2     

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 changed the title Test fix 5638test: disable ex_libpmem2/TEST6 for 'helgrind' until #5638 is fixed test: disable ex_libpmem2/TEST6 for 'helgrind' until #5638 is fixed May 22, 2023
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit edf74c7 into pmem:stable-1.13 May 22, 2023
@grom72 grom72 deleted the test-fix-5638 branch May 25, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants