-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix pmem2_mover/TEST1 with memcheck for #5678 #5679
Conversation
Codecov Report
@@ Coverage Diff @@
## stable-1.13 #5679 +/- ##
===============================================
- Coverage 74.27% 72.25% -2.02%
===============================================
Files 145 145
Lines 22131 22633 +502
Branches 3704 3771 +67
===============================================
- Hits 16437 16354 -83
- Misses 5694 6279 +585 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
src/test/pmem2_mover/pmem2_mover.c
line 120 at r1 (raw file):
pmem2_source_delete(&src); CLOSE(fd); free(buffer_data);
Nitpick: It would be nice to create and destroy resources in precisely the opposite order. I know buffer_data
is unrelated but still I consider it a good practice.
Fixes: pmem#5678. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
Fixes: #5678.
This change is