Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix pmem2_mover/TEST1 with memcheck for #5678 #5679

Merged
merged 1 commit into from
May 23, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 23, 2023

Fixes: #5678.


This change is Reviewable

@grom72 grom72 added the QA: CI .github/ and utils/ related to automated testing label May 23, 2023
@grom72 grom72 added this to the 1.13 on GHA milestone May 23, 2023
@grom72 grom72 requested review from janekmi and osalyk May 23, 2023 04:15
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #5679 (179b913) into stable-1.13 (67ce085) will decrease coverage by 2.02%.
The diff coverage is n/a.

❗ Current head 179b913 differs from pull request most recent head c727221. Consider uploading reports for the commit c727221 to get more accurate results

@@               Coverage Diff               @@
##           stable-1.13    #5679      +/-   ##
===============================================
- Coverage        74.27%   72.25%   -2.02%     
===============================================
  Files              145      145              
  Lines            22131    22633     +502     
  Branches          3704     3771      +67     
===============================================
- Hits             16437    16354      -83     
- Misses            5694     6279     +585     

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)


src/test/pmem2_mover/pmem2_mover.c line 120 at r1 (raw file):

	pmem2_source_delete(&src);
	CLOSE(fd);
	free(buffer_data);

Nitpick: It would be nice to create and destroy resources in precisely the opposite order. I know buffer_data is unrelated but still I consider it a good practice.

Fixes: pmem#5678.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @grom72)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit 251b6be into pmem:stable-1.13 May 23, 2023
@grom72 grom72 deleted the test-fix-5678 branch May 25, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: CI .github/ and utils/ related to automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants