Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable VARIANT_MOVDIR64B under Valgrind #6130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented Nov 20, 2024

#6129
#5640


This change is Reviewable

@osalyk osalyk added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Nov 20, 2024
@osalyk osalyk force-pushed the pmem2_mem branch 2 times, most recently from 33be252 to 78cc635 Compare November 20, 2024 16:39
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)


src/test/pmem2_mem_ext/TESTS.py line 118 at r1 (raw file):

        # XXX all tests with VARIANT_AVX512F or VARIANT_MOVDIR64B
        # are disabled under Valgrind until the issue
        # https://github.com/pmem/pmdk/issues/5640 is fixed.

Shall we also mention #6129

Suggestion:

# https://github.com/pmem/pmdk/issues/5640 and
# https://github.com/pmem/pmdk/issues/6129 are fixed

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


src/test/pmem2_mem_ext/TESTS.py line 118 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Shall we also mention #6129

Done.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants