-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable VARIANT_MOVDIR64B under Valgrind #6130
base: master
Are you sure you want to change the base?
Conversation
33be252
to
78cc635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
src/test/pmem2_mem_ext/TESTS.py
line 118 at r1 (raw file):
# XXX all tests with VARIANT_AVX512F or VARIANT_MOVDIR64B # are disabled under Valgrind until the issue # https://github.com/pmem/pmdk/issues/5640 is fixed.
Shall we also mention #6129
Suggestion:
# https://github.com/pmem/pmdk/issues/5640 and
# https://github.com/pmem/pmdk/issues/6129 are fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
src/test/pmem2_mem_ext/TESTS.py
line 118 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Shall we also mention #6129
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
#6129
#5640
This change is