Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: check clang version #6139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

common: check clang version #6139

wants to merge 1 commit into from

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented Feb 6, 2025

@osalyk osalyk added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Feb 6, 2025
@osalyk osalyk requested review from grom72 and janekmi February 6, 2025 11:29
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)


src/core/util.h line 336 at r1 (raw file):

/* tell clang to ignore the "cast-function-type-strict" warning */
#if defined(__clang__) && __clang_major__ >= 18

Just to be sure, how we determined it is not necessary for __clang_major__ < 18?

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)


src/core/util.h line 336 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Just to be sure, how we determined it is not necessary for __clang_major__ < 18?

Release notes from llvm.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)


src/core/util.h line 336 at r1 (raw file):

Previously, osalyk (Oksana Sałyk) wrote…

Release notes from llvm.

are we able to test that with clang 16?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants