Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

common: remove Ubuntu 16.04 and unneeded scripts for installing ndctl and pmdk #871

Conversation

ldorau
Copy link
Member

@ldorau ldorau commented Feb 10, 2021

This change is Reviewable

Copy link

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ldorau)

a discussion (no related file):
https://github.com/pmem/rpma/blame/master/INSTALL.md#L136


@ldorau ldorau force-pushed the common-remove-unneeded-scripts-for-installing-ndctl-and-pmdk branch from 23ad873 to f351843 Compare February 10, 2021 10:39
Copy link
Member Author

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @janekmi)

a discussion (no related file):

Previously, janekmi (Jan Michalski) wrote…

https://github.com/pmem/rpma/blame/master/INSTALL.md#L136

Done.


Copy link

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ldorau)


INSTALL.md, line 143 at r2 (raw file):

OSes not tested anymore:

Known supported but not validated OSes:

Copy link
Member Author

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


INSTALL.md, line 143 at r2 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…
OSes not tested anymore:

Known supported but not validated OSes:

No, we are not sure they will be supported. They can become unsupported and we will not get to know that, because we are not testing them anymore.

Copy link
Member Author

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


INSTALL.md, line 143 at r2 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

No, we are not sure they will be supported. They can become unsupported and we will not get to know that, because we are not testing them anymore.

So rather something like:

"OSes that were supported, but we stopped to validate them:"

Copy link

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


INSTALL.md, line 143 at r2 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

So rather something like:

"OSes that were supported, but we stopped to validate them:"

In short: OSes not tested anymore. ;-)

Copy link
Member Author

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


INSTALL.md, line 143 at r2 (raw file):

Previously, janekmi (Jan Michalski) wrote…

In short: OSes not tested anymore. ;-)

:-)

Copy link

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)


INSTALL.md, line 143 at r2 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

:-)

So they are not supported anymore and no point to list them here.
I would propose to add the removal of Ubuntu 16.04 to https://github.com/pmem/rpma/blob/master/CHANGELOG.md.

@ldorau ldorau force-pushed the common-remove-unneeded-scripts-for-installing-ndctl-and-pmdk branch from f351843 to 3ff979c Compare February 11, 2021 06:57
Copy link
Member Author

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


INSTALL.md, line 143 at r2 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

So they are not supported anymore and no point to list them here.
I would propose to add the removal of Ubuntu 16.04 to https://github.com/pmem/rpma/blob/master/CHANGELOG.md.

Removed.

The changelog should be updated before the release - it is not a part of this PR.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 7 files at r1, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

@ldorau ldorau merged commit 448bac2 into pmem:master Feb 11, 2021
@ldorau ldorau deleted the common-remove-unneeded-scripts-for-installing-ndctl-and-pmdk branch February 11, 2021 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants