-
Notifications
You must be signed in to change notification settings - Fork 56
common: remove Ubuntu 16.04 and unneeded scripts for installing ndctl and pmdk #871
common: remove Ubuntu 16.04 and unneeded scripts for installing ndctl and pmdk #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ldorau)
a discussion (no related file):
https://github.com/pmem/rpma/blame/master/INSTALL.md#L136
23ad873
to
f351843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @janekmi)
a discussion (no related file):
Previously, janekmi (Jan Michalski) wrote…
https://github.com/pmem/rpma/blame/master/INSTALL.md#L136
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ldorau)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ldorau)
INSTALL.md, line 143 at r2 (raw file):
OSes not tested anymore:
Known supported but not validated OSes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
INSTALL.md, line 143 at r2 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
OSes not tested anymore:
Known supported but not validated OSes:
No, we are not sure they will be supported. They can become unsupported and we will not get to know that, because we are not testing them anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
INSTALL.md, line 143 at r2 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
No, we are not sure they will be supported. They can become unsupported and we will not get to know that, because we are not testing them anymore.
So rather something like:
"OSes that were supported, but we stopped to validate them:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
INSTALL.md, line 143 at r2 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
So rather something like:
"OSes that were supported, but we stopped to validate them:"
In short: OSes not tested anymore
. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
INSTALL.md, line 143 at r2 (raw file):
Previously, janekmi (Jan Michalski) wrote…
In short:
OSes not tested anymore
. ;-)
:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
INSTALL.md, line 143 at r2 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
:-)
So they are not supported anymore and no point to list them here.
I would propose to add the removal of Ubuntu 16.04 to https://github.com/pmem/rpma/blob/master/CHANGELOG.md.
f351843
to
3ff979c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
INSTALL.md, line 143 at r2 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
So they are not supported anymore and no point to list them here.
I would propose to add the removal of Ubuntu 16.04 to https://github.com/pmem/rpma/blob/master/CHANGELOG.md.
Removed.
The changelog should be updated before the release - it is not a part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ldorau)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ldorau)
This change is