-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autorun fixes #101
Merged
Merged
Autorun fixes #101
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ef809e5
Add new scripts/README; explain logging subtleties
marc-hb 9e324e5
run_qemu.sh: extract new function generatedfrom_header()
marc-hb 66fd061
run_qemu.sh: use presets to enable basic OS services
marc-hb 88c1f95
run_qemu.sh: use .preset instead of symlinks to fix --autorun option
marc-hb 9ad89c3
rq_cxl_tests.sh: don't silently timeout when /root/ndctl is missing
marc-hb 03be261
rq_cxl_tests.sh: remove spurious, trailing 'systemctl poweroff'
marc-hb 04cf33c
rq_cxl_results.sh: stop expecting logs from cxl/core/regs.c
marc-hb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was needed to actually shutdown the guest fully and exit the qemu process (when I last ran/tested this) - without it, even after a successful completion of all the tests, we'd end up waiting for the timeout to kill it and exit. Does that not happen anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not happen because there is (more recently?) a
trap EXIT, check the commit message.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see - makes sense, the rest of it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impossible to tell from the git log because both
poweroffcommands came in the same, very first commit.Anyway I tested this multiple times and a single
poweroffcommand is enough.I found that because sometimes you want to LOCALLY comment it out for temporary testing and doing this twice was not convenient :-)