-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Attribute declared but not referenced script #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a script to list all of the attributes that have been declared but have no reference in the document outside of the declaration. * Fixes a typo in the internal cross referencing * Add a new make target `make check` that runs this additional check and displays the list of attributes missing a reference. * Ref Issue pmix#185 Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> (cherry picked from commit a5f3bf1)
This is probably useful to have in the v3 standard as an option as well. Here is the report out for the v3 branch:
|
Cherry Pick of PR #223 |
@rhc54 can you give this a 👍 and merge for the v3.x branch? That way we have the script over there too if we need it. |
rhc54
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but have no reference in the document outside of the declaration.
make check
that runs this additional checkand displays the list of attributes missing a reference.