Missing v4 patches #330
Merged
Missing v4 patches #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jjhursey
commented
Jan 29, 2021
jjhursey
commented
- master version of PR Update tools chapter #315 that went into v4
- With this master and v4 are in sync.
Give more details on the indirect launch case, including separation of the case where the tool knows how to parse its cmd line to extract the launcher vs any applications, and the case where the tool does NOT know how to parse the cmd line. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 3e1f249)
Signed-off-by: Ralph Castain <rhc@pmix.org> Co-authored-by: Josh Hursey <4259120+jjhursey@users.noreply.github.com> (cherry picked from commit 69d1643)
|
I found this mistake while working on the debugger use case for PR #328. I noticed master was missing an attribute ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.