v4: Sync errata to v4 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't recall why this was never defined. We may need to think about this. Certainly I could have just said, "A tool is a process that calls PMIx_tool_init()" but I wanted to carefully contrast it with a client so I defined it in similar language even though it uses the gramatically wasteful approach of X is either a FOO or ~FOO and BAR. We could have said a client is a process that calls PMIx_Init(), but we didn't because how it is started is important in some way. Signed-off-by: dsolt@us.ibm.com (cherry picked from commit e353b48)
I have specifically written this in such a way that ignores the case where a process is registered as a client (e.g. created through PMIX_Spawn), but then chooses to call PMIx_tool_init() instead of PMIx_Init(). I did not say, "PMIX_PARENT_ID is only set for pmix clients and not tools". I also did not preclude having some launcher that is part of the system (pmixlaunch, mpirun, jsrun, etc) that spawns processes through some means other than PMIX_Spawn and still sets PMIX_PARENT_ID. I only say that it must be set if you were created by PMIX_Spawn. Signed-off-by: dsolt@us.ibm.com (cherry picked from commit 7d73128)
Signed-off-by: dsolt@us.ibm.com (cherry picked from commit 8338e65)
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring over:
Two additional commits to: