Issue 175 make query chap -rebased on master #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhursey
added
Accepted as Stable
|
This PR is #391 but updated to match the current state of Dave and I decided to create a new PR instead of rebasing the old PR because of the size of the changes. This will allow us to more easily view the changes side-by-side to make sure nothing is lost in the rebase. |
jjhursey
requested changes
May 25, 2022
Can squash this later which will get rid of this move, but I do it this way so that you can see how we changed the text in this new chapter instead of it all appearing as if it is new text. Signed-off-by: dsolt@us.ibm.com
jjhursey
force-pushed
the
issue_175_make_query_chap_rb
branch
from
3499152 to
1efa85d
Compare
Especially separating out attributes from keys, moving query structure to the start of the chapter and adding chapter headings, etc. Signed-off-by: dsolt@us.ibm.com
Signed-off-by: dsolt@us.ibm.com
singular use of query vs queries in intro permissable -> permissible any keys -> any particular keys when describing what implementations must support block of text that was accidentally not moved with the list of attributes that where moved. similified -> simplified Signed-off-by: dsolt@us.ibm.com
jjhursey
force-pushed
the
issue_175_make_query_chap_rb
branch
from
1efa85d to
1040b6c
Compare
jjhursey
approved these changes
May 26, 2022
This was referenced May 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of pr#391. This is the one we actually want to merge, but we need to make sure it is applying the same changes as 391.