fix: replace ansi-html with ansi-html-community #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait a bit on this one. Given that our use case directly consumes errors from Webpack's stats, the risk of hitting a ReDoS is low. I do notice that |
boppaaronPFG
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
This is the same fix that was implemented for webpack-dev-server.
|
@pmmmwh Thank you for your answer. Since webpack-dev-server have patched it with the same community library, I guess we could try to rely on it too: https://github.com/webpack/webpack-dev-server/releases/tag/v4.1.1. It could be considered a temporary fix though. |
pmmmwh
approved these changes
Sep 11, 2021
aruniverse
added a commit
to imodeljs/create-react-app
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ReDoS vulnerability CVE-2021-23424.
See: Tjatse/ansi-html#19 (comment)