Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowable blocks now can't be placed inside liquid #5392

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

ipad54
Copy link
Member

@ipad54 ipad54 commented Nov 5, 2022

Introduction

In vanilla flowable blocks cannot be placed inside liquid

Relevant issues

This PR also fixes #4783

Tests

https://www.youtube.com/watch?v=giquIOIvQ4E

@dktapps
Copy link
Member

dktapps commented Nov 7, 2022

A simpler and more robust method would be to alter Liquid::canBeReplacedBy() and add a check for isFlowable().

Never mind, apparently I dreamed that such a method existed.

@jasonw4331 jasonw4331 added Category: Gameplay Related to Minecraft gameplay experience Type: Fix Bug fix, typo fix, or any other fix labels Nov 22, 2022
Copy link
Member

@ShockedPlot7560 ShockedPlot7560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

Joshy3282 added a commit to Joshy3282/PocketMine-MP that referenced this pull request Oct 2, 2024
@dktapps dktapps merged commit b5469de into pmmp:stable Nov 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Type: Fix Bug fix, typo fix, or any other fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bamboo can be placed underwater
5 participants