6161 implement interface common block properties #6383
Conversation
|
@dktapps Just want to get a quick review of this to make sure its headed in the intended direction |
|
Would this be better utilized trait, I think the is the direction most items like this follow. |
Probably should use the trait as there is Horizontal and AnyFacing traits that could be used Possibly out of scope? Would likely fit more into another PR for cleaning up the code |
| /** | ||
| * Set the current facing direction of the block | ||
| */ | ||
| public function setFacing(int $facing) : object; |
| @@ -40,7 +41,7 @@ | |||
| use pocketmine\world\World; | |||
| use function ceil; | |||
|
|
|||
| class Painting extends Entity{ | |||
| class Painting extends Entity implements FacingInterface{ | |||
There was a problem hiding this comment.
Design error, you're using an interface made for blocks in an entity, I don't think you should do that
ShockedPlot7560
added
Category: API
|
This PR has been marked as "Waiting on Author", but we haven't seen any activity in 7 days. If there is no further activity, it will be closed in 28 days. Note for maintainers: Adding an assignee to the PR will prevent it from being marked as stale. |
|
Closing due to lack of response to review comments |
dktapps
added
Resolution: Abandoned
Introduction
The goal of this is to give plugins an easier way of accessing common properties of blocks such as facing and on/off
Relevant issues
Fixes #6161