Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: pass object to convexPolyhedron #6

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

stockhuman
Copy link
Member

How do we feel about passing vertices, faces, normals and other information to the ConvexPolyhedron constructor as an object?

constructor({ vertices = [], faces = [], normals = [], axes, boundingSphereRadius }) {

I feel as if it makes passing available data, especially with gaps in it, a little easier.

@codynova
Copy link
Member

Seems fine to me. I think it could even be an overload if there is a need to maintain backwards compatibility (not likely IMO)

@stockhuman stockhuman merged commit 090b8c1 into master Mar 17, 2020
stockhuman added a commit that referenced this pull request Mar 19, 2020
Silly mistake - facenormals never computed, even when not supplied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants