Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In softShadows the frustum attribute is being called frustrum #242

Closed
gsimone opened this issue Jan 19, 2021 · 2 comments · Fixed by #243 or #259
Closed

In softShadows the frustum attribute is being called frustrum #242

gsimone opened this issue Jan 19, 2021 · 2 comments · Fixed by #243 or #259
Assignees
@joshuaellis
Labels
bug Something isn't working released on @beta released in beta for review

Comments

@gsimone
Copy link
Member

gsimone commented Jan 19, 2021 •
edited
Loading

We should probably just alias it to the correct name
@gsimone gsimone added the bug Something isn't working label Jan 19, 2021
@joshuaellis joshuaellis added the good first issue Good for newcomers label Jan 19, 2021
@joshuaellis
Copy link
Member

Is this on three?

@gsimone
Copy link
Member Author

gsimone commented Jan 19, 2021

drei/src/softShadows.tsx

Line 12 in 93d842a

frustrum = 3.75,

joshuaellis added a commit that referenced this issue Jan 19, 2021
@joshuaellis
fix: suggestion for fixing #242
13fea77
@joshuaellis joshuaellis linked a pull request Jan 19, 2021 that will close this issue
[fix] #242 Frustum has incorrect spelling in softshadows #243
Merged
joshuaellis added a commit that referenced this issue Jan 19, 2021
@joshuaellis
fix: #242 Frustum has incorrect spelling in softshadows (#243)
c76b61b 
* fix: suggestion for fixing #242

* refactor: default should be other way round

* chore: update readme with correct spelling
@joshuaellis joshuaellis added released on @beta released in beta for review and removed good first issue Good for newcomers labels Jan 19, 2021
@joshuaellis joshuaellis self-assigned this Jan 21, 2021
@joshuaellis joshuaellis mentioned this issue Jan 26, 2021
Merged
10 tasks
joshuaellis added a commit that referenced this issue Jan 28, 2021
@joshuaellis @gsimone
@Code47X @mattrossman @RenaudRohlinger @jure @jbixon13 @drcmda
BREAKING CHANGE: v3.0.0
2c38242 
* [Feature] move stories to TS (#223) (#231)

* feat: setup TS for stories

* fix: eslint was ignore .storybook

* feat: add TS to storybook

* refactor: move stories to TS (WIP)

* refactor: move more stories to TS (WIP)

* refactor: src changes for TS move over

I think these were TS problems that were missed.

* fix: ContactShadows story

* refactor: move more stories to TS

* refactor: add MapControls.tsx after raising issues in three

Two errors linked to three.js:
mrdoob/three.js#21058
mrdoob/three.js#21059

* fix: TS errors for passing refs & children

* refactor: add more stories (WIP)

* fix: useContextBridge TS to accept array of children

fixed using DefinitelyTyped/DefinitelyTyped#44572 (comment) because microsoft/TypeScript#14729

* refactor: convert more stories to TS

also useGLTF does not need to declare it's type

* chore: update storybook

* fix: revert useTexture

accidentally committed a WIP change

* refactor: move stories to TS (WIP)

* refactor: revert useGLTF story

* Minor type fixes

* chore: update react-three-fiber to latest

Required for Types

* refactor: move stories to TS

* fix: shaderMaterial on init returns void, not null

* refactor: remove unnecessary type in useFBX

* refactor: type Environment stronger

there was issues with useAsset not understanding it's types....

* Fixes CSB CI (#230)

Co-authored-by: Gianmarco Simone <gianmarcosimone89@gmail.com>

Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>

* 2.2.16

* chore: add templates (#232)

* chore: add react-dom as optional peer depency

if you're using react-native you don't need it.

* docs: update readme

* fix: fix storybook imports that should have been done before

* BREAKING CHANGE: refactor internal to solve react-native imports

my bad.

Co-authored-by: Gianmarco <gianmarcosimone89@gmail.com>

* 2.3.0-beta.0

* fix: edit transformOutputPath to remove .ts from files

* 2.3.0-beta.1

* fix: useAnimations ref type & chore: add storybook entry for useAnimations

* Added THREE.Group to useAnimations types

* Small refactor

* Added useAnimations story

* Clean up storybook

* Fix null ref typing on useAnimations

* Forgot to change typing on useAnimations api

* chore: add storybook entry to README

Co-authored-by: Josh Ellis <joshua.ellis18@gmail.com>

* [fix] Blob is undefined when using SSR (#239)

* fix: #233 Blob is undefined in SSR

* refactor: it appears Billboard is fixed

Looks like Typescript does not suck.

* 2.3.0-beta.2

* fix: create polyfill for atob

* 2.3.0-beta.3

* chore: update readme in response to #240

* fix: #242 Frustum has incorrect spelling in softshadows (#243)

* fix: suggestion for fixing #242

* refactor: default should be other way round

* chore: update readme with correct spelling

* 2.3.0-beta.4

* feat: Add MeshoptDecoder support to useGLTF (#246)

* Add MeshoptDecoder support to useGLTF

* chore: move center

Co-authored-by: Josh Ellis <joshua.ellis18@gmail.com>

* 2.3.0-beta.5

* feat: #181 – adding points to line (#247)

* feat: re-create geometry on new points

* refactor: useMemo the geometry instead of useEffect

* 2.3.0-beta.6

* 3.0.0-beta.1

* 3.0.0-beta.2

* feat: update troika with new features (#255)

* 3.0.0-beta.3

* feat: add ability to add custom scene as prop (#256)

* feat: add ability to add custom scene as prop

* docs: update Environment with new feats

* 3.0.0-beta.4

* refactor: shuffle imports for beta

* 3.0.0-beta.5

* docs: clearly specify name of package & old has been deprecated

* BREAKING CHANGE: Upgrade Three.js to r125 (#262)

* chore: update Three.js dependency

* refactor: remove subdivision modifier

* fix: remove use of FaceNormalsHelper as it no longer exists in Three

* fix: update typings for THREE

* fix: update modifiers to work without THREE.Geometry

* docs: update README

* chore: add Three.js peer dependency

* fix: change install instructions to use yarn instead of npm (#265)

* repurpose reflector, make it capable to blur (#260)

* repurpose reflector, make it capable to blur

* refactor: move materials out to reduce noise & fix types

* refactor: merge beta

* fix: add child propType

* refactor: update reflector story & fix children type

* changes

* fix: shuffle types so reflectorProps come from what the material expects

* docs

Co-authored-by: Josh Ellis <joshua.ellis18@gmail.com>

* chore: add workflows to beta release

* BREAKING CHANGE force build

* 3.0.0-beta.6

Co-authored-by: Gianmarco Simone <gianmarcosimone89@gmail.com>
Co-authored-by: Tanner Hartwig <tanner.hartwig57@gmail.com>
Co-authored-by: Matt Rossman <rossman@gatech.edu>
Co-authored-by: Renaud Rohlinger <renaud.rohlinger@gmail.com>
Co-authored-by: Jure Triglav <juretriglav@gmail.com>
Co-authored-by: Jason Bixon <jbixon13@gmail.com>
Co-authored-by: Paul Henschel <drcmda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuaellis joshuaellis

Labels
bug Something isn't working released on @beta released in beta for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] #242 Frustum has incorrect spelling in softshadows pmndrs/drei
[RC] v3.0.0 pmndrs/drei
2 participants
@gsimone @joshuaellis