New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeviceOrientationControls is missing invalidate on change #72

Closed

gsimone opened this issue Jul 25, 2020 · 1 comment · Fixed by #106

Member

gsimone commented Jul 25, 2020 •

edited

Loading

We added DeviceOrientationControls in #66 but THREE.DeviceOrientationControls doesn't dispatch a change event:
https://github.com/mrdoob/three.js/blob/master/examples/jsm/controls/DeviceOrientationControls.js

Same for FlyControls ( being added in #64 )
https://github.com/mrdoob/three.js/blob/master/examples/jsm/controls/FlyControls.js

Compare to OrbitControls
https://github.com/mrdoob/three.js/blob/b5c272cf408cb33153190fa715d81581bd95ee47/examples/jsm/controls/OrbitControls.js#L266

If we want to keep consistency between all controls, we would need to either open an issue or PR on three.

Member Author

gsimone commented Jul 25, 2020

Opened a PR on three.js mrdoob/three.js#19924

drcmda mentioned this issue

making drei treeshakable #106

Merged

18 tasks

gsimone closed this as completed in #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment