Adds EventDispatcher and change event to DeviceOrientationControls and FlyControls

[gsimone]

Implementation is lifted from OrbitControls, it checks dot product for quaternion change and dist Squared for position change

Types now extend EventDispatcher

[Mugen87]

Can you please edit the files in the examples/js directory instead and then generate the modules via:

node utils/modularize.js

[gsimone]

Made the changes to the js versions and built the jsm ones 👍

[Mugen87]

Looks good now!

Can you please also update the docs for both classes? The idea is to add a new section called Events similar to the other pages e.g. https://threejs.org/docs/index.html#examples/en/controls/OrbitControls

[gsimone]

I only added the Change event to both controls, do you think it's worth adding start and end? ( taking Orbit as an example ) Should be easy enough to do.

[Mugen87]

It's probably good if the controls fire similar events if possible. Would be great if you can have a look! 👍

[gsimone]

I was adding the events but realized that while OrbitControls have precise start and end times ( ie. when the user clicks ), fly and deviceOrientation don't, it's always being updated and doesn't really start/end

So I just committed the doc changes, if you think the two controls need more events I can look into that but I would open a new issue and PR

[gsimone]

Hi 👋
Is there anything missing to merge this?

[Mugen87]

Is there anything missing to merge this?

@mrdoob still needs to review the PR 👍

[mrdoob]

Thanks!