Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add treeshakable to useProgress #1981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mayank1513
Copy link

@mayank1513 mayank1513 commented Jun 4, 2024

This will ensure that only one instance of useProgess is created. For more info please see https://github.com/react18-tools/treeshakable/ and https://treeshakable.vercel.app/

Why

Enhancement: allow importing from the component files, e.g., ./web/Loader to avoid importing unnecessary code.

What

Wrapped store creation inside treeshakable

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

This will ensure that only one instance of useProgess is created.
For more info please see https://github.com/react18-tools/treeshakable/ and https://treeshakable.vercel.app/
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 5:09am

Copy link

codesandbox-ci bot commented Jun 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@mayank1513
Copy link
Author

Not updating KeyboardControls as the store is created within the component and passed to children using context. Updating this will require breaking changes.

Copy link

Thank you for your work on this pull request! We’re marking this PR as stale to encourage a final push to bring it across the finish line.

Any update, comment, or change to the PR will automatically remove the stale label so it stays active in our workflow.

If you need any help, don’t hesitate to connect with us on Discord for feedback and support. This PR will close automatically soon if there’s no further activity, but we’re here to help if you’re interested in getting it merged. Thank you for your contribution!

@github-actions github-actions bot added the Stale Inactive issue label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant