Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csg bunny #33

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix csg bunny #33

merged 1 commit into from
Aug 1, 2024

Conversation

rndexe
Copy link
Contributor

@rndexe rndexe commented Jul 31, 2024

  1. Set precise={false} on Center. Not sure why this fixes the error, might be related to
    Box3: Better support for animated objects in expandByObject() in precise mode. mrdoob/three.js#26919 and a combination of csg mesh, it works fine on other meshes.

On further analysis the regression does appear in r158 of threejs where this change was made. Not sure if this counts as an edge case which was missed.

Default value in drei Center is precise = true

  1. Fix AccumulativeShadows alphaTest and RandomizedLight intensity
  2. Change Environment blur to backgroundBluriness
  • ready to merge

@abernier
Copy link
Member

abernier commented Aug 1, 2024

is this one also ready?

@rndexe
Copy link
Contributor Author

rndexe commented Aug 1, 2024

I'm not sure if this is an introduced bug in three in how it handles precise Box3.setFromObject calculations, or a bug in three-bvh-csg. But yeah the example is no longer broken if that's all that matters.

@abernier abernier merged commit 38f4f78 into pmndrs:main Aug 1, 2024
2 checks passed
@rndexe rndexe deleted the csg-bunny branch August 1, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants