chore: enable isolatedDeclarations (#2687)

* experimental: enable isolatedDeclarations * update typescript
pmndrs · Sep 15, 2024 · a26203e · a26203e
1 parent ab68d4d
commit a26203e
Show file tree

Hide file tree

Showing 6 changed files with 55 additions and 50 deletions.
diff --git a/.github/workflows/test-old-typescript.yml b/.github/workflows/test-old-typescript.yml
@@ -41,6 +41,9 @@ jobs:
           cache-dependency-path: '**/pnpm-lock.yaml'
       - run: pnpm install --frozen-lockfile
       - run: pnpm build
+      - name: Patch for all TS
+        run: |
+          sed -i~ 's/"isolatedDeclarations": true,//' tsconfig.json
       - name: Patch for v4/v3 TS
         if: ${{ startsWith(matrix.typescript, '4.') || startsWith(matrix.typescript, '3.') }}
         run: |

diff --git a/package.json b/package.json
@@ -169,7 +169,7 @@
     "ts-expect": "^1.3.0",
     "ts-node": "^10.9.2",
     "tslib": "^2.6.3",
-    "typescript": "^5.5.4",
+    "typescript": "^5.6.2",
     "vitest": "^2.0.5",
     "wonka": "^6.3.4"
   },

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/babel/utils.ts b/src/babel/utils.ts
@@ -8,7 +8,7 @@ export function isAtom(
   t: typeof types,
   callee: babel.types.Expression | babel.types.V8IntrinsicIdentifier,
   customAtomNames: PluginOptions['customAtomNames'] = [],
-) {
+): boolean {
   const atomNames = [...atomFunctionNames, ...customAtomNames]
   if (t.isIdentifier(callee) && atomNames.includes(callee.name)) {
     return true

diff --git a/src/vanilla/utils/constants.ts b/src/vanilla/utils/constants.ts
@@ -1,3 +1,3 @@
-export const RESET = Symbol(
+export const RESET: unique symbol = Symbol(
   import.meta.env?.MODE !== 'production' ? 'RESET' : '',
 )
diff --git a/tsconfig.json b/tsconfig.json
@@ -11,6 +11,8 @@
     "noUncheckedIndexedAccess": true,
     "exactOptionalPropertyTypes": true,
     "verbatimModuleSyntax": true,
+    "declaration": true,
+    "isolatedDeclarations": true,
     "noEmit": true,
     "baseUrl": ".",
     "paths": {