fix(utils): improve unstable_unwrap for sometimes async atom #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 746b463:
|
|
Size Change: +34 B (0%) Total Size: 67.1 kB
ℹ️ View Unchanged
|
kodiakhq bot
referenced
this pull request
in sullivanpj/open-system
Jun 26, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jotai](https://togithub.com/pmndrs/jotai) | [`2.1.0` -> `2.2.1`](https://renovatebot.com/diffs/npm/jotai/2.1.0/2.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/jotai (jotai)</summary> ### [`v2.2.1`](https://togithub.com/pmndrs/jotai/releases/tag/v2.2.1) [Compare Source](https://togithub.com/pmndrs/jotai/compare/v2.2.0...v2.2.1) This includes some improvements in `jotai/utils`. Especially, `unstable_unwrap` is getting to be stable. ##### What's Changed - feat(utils/useHydrateAtoms) - Optionally rehydrate with force hydrate by [@​SariSabouh](https://togithub.com/SariSabouh) in [https://github.com/pmndrs/jotai/pull/1990](https://togithub.com/pmndrs/jotai/pull/1990) - fix(utils): revert atomWithStorage typing by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1994](https://togithub.com/pmndrs/jotai/pull/1994) - fix(utils): improve selectAtom typing by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1995](https://togithub.com/pmndrs/jotai/pull/1995) - fix(utils): improve unstable_unwrap for sometimes async atom by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1996](https://togithub.com/pmndrs/jotai/pull/1996) - fix(utils): unstable_unwrap to support writable atom by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1997](https://togithub.com/pmndrs/jotai/pull/1997) ##### New Contributors - [@​SariSabouh](https://togithub.com/SariSabouh) made their first contribution in [https://github.com/pmndrs/jotai/pull/1990](https://togithub.com/pmndrs/jotai/pull/1990) **Full Changelog**: pmndrs/jotai@v2.2.0...v2.2.1 ### [`v2.2.0`](https://togithub.com/pmndrs/jotai/releases/tag/v2.2.0) [Compare Source](https://togithub.com/pmndrs/jotai/compare/v2.1.1...v2.2.0) It includes a few improvements. Some utils are rewritten as there was a misconception when migrating from v1. ESM builds are optimized for Vite users. #### Migration Guide for `jotai/utils` ##### `atomWithDefault` ```js // suppose we have this const asyncAtom = atom(() => Promise.resolve(1)) const countAtom = atomWithDefault((get) => get(asyncAtom)) // and in component const setCount = useSetAtom(countAtom) // previously, setCount((c) => c + 1) // it worked, but it will no longer work // instead, you need to do this setCount((countPromise) => countPromise.then((c) => c + 1)) ``` ##### `atomWithStorage` ```js // suppose we have async storage const storage = createJSONStorage(() => AsyncStorage) const countAtom = atomWithStorage('count-key', 0, storage) // in component const [count, setCount] = useAtom(countAom) // previously, countAtom is a sync atom, so you could update like this: setCount((c) => c + 1) // with the new version, it becomes async occasionally, so you need to resolve it: setCount(async (c) => (await c) + 1) ``` #### What's Changed - breaking(utils): predictable atomWithDefault by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1939](https://togithub.com/pmndrs/jotai/pull/1939) - breaking(utils): improve atomWithStorage by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1958](https://togithub.com/pmndrs/jotai/pull/1958) - feat(vanilla): new store listeners for devtools by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1966](https://togithub.com/pmndrs/jotai/pull/1966) - fix(build): mode env for "import" condition" by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1978](https://togithub.com/pmndrs/jotai/pull/1978) #### New Contributors - [@​reinierkaper-carewell](https://togithub.com/reinierkaper-carewell) made their first contribution in [https://github.com/pmndrs/jotai/pull/1980](https://togithub.com/pmndrs/jotai/pull/1980) **Full Changelog**: pmndrs/jotai@v2.1.1...v2.2.0 ### [`v2.1.1`](https://togithub.com/pmndrs/jotai/releases/tag/v2.1.1) [Compare Source](https://togithub.com/pmndrs/jotai/compare/v2.1.0...v2.1.1) This version fixes some issues in edge cases. #### What's Changed - fix(vanilla): Stable promise by [@​backbone87](https://togithub.com/backbone87) in [https://github.com/pmndrs/jotai/pull/1933](https://togithub.com/pmndrs/jotai/pull/1933) - fix(vanilla): update atoms with tree structure dependencies (regression from v1) by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1959](https://togithub.com/pmndrs/jotai/pull/1959) - fix: prefer PromiseLike where appropriate by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/1967](https://togithub.com/pmndrs/jotai/pull/1967) #### New Contributors - [@​blissdev](https://togithub.com/blissdev) made their first contribution in [https://github.com/pmndrs/jotai/pull/1945](https://togithub.com/pmndrs/jotai/pull/1945) - [@​hwanyoungChoi](https://togithub.com/hwanyoungChoi) made their first contribution in [https://github.com/pmndrs/jotai/pull/1957](https://togithub.com/pmndrs/jotai/pull/1957) - [@​alexhad6](https://togithub.com/alexhad6) made their first contribution in [https://github.com/pmndrs/jotai/pull/1971](https://togithub.com/pmndrs/jotai/pull/1971) - [@​backbone87](https://togithub.com/backbone87) made their first contribution in [https://github.com/pmndrs/jotai/pull/1933](https://togithub.com/pmndrs/jotai/pull/1933) **Full Changelog**: pmndrs/jotai@v2.1.0...v2.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sullivanpj/open-system).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we need to wrap a sometime async atom to be full async.
#1988 (reply in thread)