Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vanilla): check duplicated instances #2049

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jul 27, 2023

Related Issues or Discussions

Fixes #2044

Summary

Add a DEV-only warning message if duplication is detected.

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview Jul 27, 2023 1:35pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e47efb:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

Size Change: +432 B (+1%)

Total Size: 67.9 kB

Filename Size Change
dist/system/vanilla.development.js 3.96 kB +147 B (+4%)
dist/umd/vanilla.development.js 4.71 kB +137 B (+3%)
dist/vanilla.js 4.62 kB +148 B (+3%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 916 B
dist/babel/plugin-react-refresh.js 1.15 kB
dist/babel/preset.js 1.39 kB
dist/index.js 242 B
dist/react.js 1.05 kB
dist/react/utils.js 1.26 kB
dist/system/babel/plugin-debug-label.development.js 1.09 kB
dist/system/babel/plugin-debug-label.production.js 764 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 935 B
dist/system/babel/preset.development.js 1.57 kB
dist/system/babel/preset.production.js 1.14 kB
dist/system/index.development.js 236 B
dist/system/index.production.js 167 B
dist/system/react.development.js 1.17 kB
dist/system/react.production.js 701 B
dist/system/react/utils.development.js 713 B
dist/system/react/utils.production.js 451 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 175 B
dist/system/vanilla.production.js 1.92 kB
dist/system/vanilla/utils.development.js 4.51 kB
dist/system/vanilla/utils.production.js 2.76 kB
dist/umd/babel/plugin-debug-label.development.js 1.07 kB
dist/umd/babel/plugin-debug-label.production.js 850 B
dist/umd/babel/plugin-react-refresh.development.js 1.29 kB
dist/umd/babel/plugin-react-refresh.production.js 1.02 kB
dist/umd/babel/preset.development.js 1.53 kB
dist/umd/babel/preset.production.js 1.25 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.42 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla.production.js 2.12 kB
dist/umd/vanilla/utils.development.js 5.24 kB
dist/umd/vanilla/utils.production.js 3.23 kB
dist/utils.js 246 B
dist/vanilla/utils.js 5.1 kB

compressed-size-action

@dai-shi dai-shi marked this pull request as ready for review July 27, 2023 14:30
@dai-shi dai-shi merged commit 21d4ab7 into main Jul 31, 2023
@dai-shi dai-shi deleted the fix/vanilla/check-duplicated-instances branch July 31, 2023 00:15
@dai-shi dai-shi added this to the v2.2.3 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant