Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix livecodes template #2392

Merged
merged 3 commits into from
Feb 12, 2024
Merged

fix livecodes template #2392

merged 3 commits into from
Feb 12, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Feb 11, 2024

Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2024 11:29am

Copy link

codesandbox-ci bot commented Feb 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c69f598:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

"jotai/vanilla/utils": "{{LC::TO_DATA_URL(./dist/esm/vanilla/utils.mjs)}}",
"jotai/react/utils": "{{LC::TO_DATA_URL(./dist/esm/react/utils.mjs)}}"
"customSettings": {
"jotai commit number used": "can we show something here?",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hatemhosny It doesn't have to be in customSettings, but is there a way to show the commit used in the imports?

Copy link

github-actions bot commented Feb 11, 2024

Size Change: 0 B

Total Size: 70.8 kB

ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 907 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.38 kB
dist/index.js 242 B
dist/react.js 1.06 kB
dist/react/utils.js 1.26 kB
dist/system/babel/plugin-debug-label.development.js 1.09 kB
dist/system/babel/plugin-debug-label.production.js 757 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.56 kB
dist/system/babel/preset.production.js 1.13 kB
dist/system/index.development.js 253 B
dist/system/index.production.js 182 B
dist/system/react.development.js 1.18 kB
dist/system/react.production.js 711 B
dist/system/react/utils.development.js 722 B
dist/system/react/utils.production.js 461 B
dist/system/utils.development.js 258 B
dist/system/utils.production.js 188 B
dist/system/vanilla.development.js 4.16 kB
dist/system/vanilla.production.js 2.09 kB
dist/system/vanilla/utils.development.js 4.73 kB
dist/system/vanilla/utils.production.js 2.88 kB
dist/umd/babel/plugin-debug-label.development.js 1.06 kB
dist/umd/babel/plugin-debug-label.production.js 845 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.53 kB
dist/umd/babel/preset.production.js 1.24 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.43 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla.development.js 4.96 kB
dist/umd/vanilla.production.js 2.68 kB
dist/umd/vanilla/utils.development.js 5.64 kB
dist/umd/vanilla/utils.production.js 3.47 kB
dist/utils.js 246 B
dist/vanilla.js 4.88 kB
dist/vanilla/utils.js 5.5 kB

compressed-size-action

Copy link

github-actions bot commented Feb 11, 2024

LiveCodes Preview in LiveCodes

Latest commit: c69f598
Last updated: Feb 11, 2024 11:28am (UTC)

Playground Link
React demo https://livecodes.io?x=id/HAAJSBFFM

See documentations for usage instructions.

.livecodes/react.json Outdated Show resolved Hide resolved
@hatemhosny
Copy link

Alternatively, in the HTML footer or may be console.log

Please note that the editors (markup, style, script) can have a hiddenContent property that has code that runs without being shown in the code editor.

You may use this to log commit number without showing that code in the editor.

https://livecodes.io/docs/configuration/configuration-object#markup

@dai-shi
Copy link
Member Author

dai-shi commented Feb 11, 2024

Yeah, but I'm thinking about removing "imports" in custom settings, say, to reproduce a bug. So, it makes sense to have the sha close to "imports".

@hatemhosny
Copy link

for convenience, you can now also use {{LC::SHORT_SHA}} to match the 7-character short SHA displayed on GitHub.

I have also updated the docs to highlight the fact that workflow_run event is only triggered from the default branch.

Thank you

@hatemhosny
Copy link

sorry, fixed short sha!
It should work now.
you may want to re-run the action.

@dai-shi dai-shi merged commit dc34c6d into main Feb 12, 2024
34 checks passed
@dai-shi dai-shi deleted the fix-livecodes-template branch February 12, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants