-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): improve freezeAtom and freezeAtomCreator #2476
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Preview in LiveCodesLatest commit: 5feadb8
See documentations for usage instructions. |
Thanks for the catch. Can you also fix it? |
de9a2ae
to
e954636
Compare
added a fix and expanded the test case to check for deep freeze. also applied the same strategy that is used in freezeAtomCreator to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for working on this.
Now, I think freezeAtomCreator
isn't very useful.
I don't think it's widely used, and it's easy to create one on users end.
I'll work on a separate PR.
Related Issues or Discussions
None
Summary
Extends the
freezeAtomCreator
test to unveil a bugCheck List
yarn run prettier
for formatting code and docs