Docs: stackblitz migration #2524
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yes, please. |
|
You want to fix the code in markdown if needed. |
| @@ -1,6 +1,6 @@ | |||
| export const Stackblitz = ({ id, file }) => { | |||
| return ( | |||
| <div className="mb-8 overflow-hidden rounded-md border-b border-gray-200 shadow-lg dark:!shadow-none sm:rounded-lg"> | |||
| <div className="mb-8 mt-4 overflow-hidden rounded-md border-b border-gray-200 shadow-lg dark:!shadow-none sm:rounded-lg"> | |||
There was a problem hiding this comment.
@sandren in case you want to review it.
There was a problem hiding this comment.
FYI, this would add some top margin to the Stackblitz block to keep it from too close to the heading above.
The related markdown looks fine and up to date. I'll try to rewrite the example code so that it make more sense. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/9AVMHKFV6 |
See documentations for usage instructions.
|
I have made change to the markdown as suggested and revise the demo with same code sample at the SSR page to make it relevant and relatable. Please check the Stackblitz demo here. |
|
Hm, I actually liked the timer clock demo, which is from the official example, AFAIR. |
|
IMO, the clock demo is good as a client-side state binding demo but it didn't use Even if I add the |
|
I see. Yeah, I think the clock demo is not about hydration. Can we keep both examples? |
|
IMO, I will only embed the new demo (as in latest commit). For the Clock demo, I'll use it to replace the clock codesandbox on the Next.js guide. Plus, there's no need to add a link to the clock demo since this SSR page already has a link to the Next.js page. |
Related Issues or Discussions
Fixes #2516
Summary
As per #2516, here's my first PR to migrate Codesandbox examples to Stackblitz. (This is my personal Github acc). While copying this particular SSR example, I found it quite irrelevant and failed to demonstrate the
useHydrateAtomswhich the example is placed at. Can I make change to the example to make it relevant and useful?Check List
yarn run prettierfor formatting code and docs