Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vanilla): fix store.ts for an edge case #2567

Merged
merged 4 commits into from
May 27, 2024
Merged

fix(vanilla): fix store.ts for an edge case #2567

merged 4 commits into from
May 27, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented May 23, 2024

Related Issues or Discussions

Fixes #2565

Summary

The issue only occurs with store.ts and react@18.
store2 doesn't have the issue and neither react@19-rc.

I'm not very confident why this change fixes the issue, so there might remain other issues somewhere else.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 4:08am

Copy link

codesandbox-ci bot commented May 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented May 23, 2024

LiveCodes Preview in LiveCodes

Latest commit: 78289f9
Last updated: May 27, 2024 4:07am (UTC)

Playground Link
React demo https://livecodes.io?x=id/52FYBWSE6

See documentations for usage instructions.

Copy link

github-actions bot commented May 23, 2024

Size Change: -72 B (-0.08%)

Total Size: 91.9 kB

Filename Size Change
dist/system/vanilla.development.js 4.33 kB -11 B (-0.25%)
dist/system/vanilla.production.js 2.19 kB -14 B (-0.64%)
dist/umd/vanilla.development.js 5.19 kB -20 B (-0.38%)
dist/umd/vanilla.production.js 2.79 kB -8 B (-0.29%)
dist/vanilla.js 5.09 kB -19 B (-0.37%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 927 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.4 kB
dist/experimental.js 4.71 kB
dist/index.js 242 B
dist/react.js 1.06 kB
dist/react/utils.js 1.4 kB
dist/system/babel/plugin-debug-label.development.js 1.1 kB
dist/system/babel/plugin-debug-label.production.js 771 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.58 kB
dist/system/babel/preset.production.js 1.14 kB
dist/system/experimental.development.js 3.83 kB
dist/system/experimental.production.js 2.04 kB
dist/system/index.development.js 253 B
dist/system/index.production.js 182 B
dist/system/react.development.js 1.18 kB
dist/system/react.production.js 711 B
dist/system/react/utils.development.js 860 B
dist/system/react/utils.production.js 461 B
dist/system/utils.development.js 258 B
dist/system/utils.production.js 188 B
dist/system/vanilla/utils.development.js 5.13 kB
dist/system/vanilla/utils.production.js 3.1 kB
dist/umd/babel/plugin-debug-label.development.js 1.08 kB
dist/umd/babel/plugin-debug-label.production.js 855 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.54 kB
dist/umd/babel/preset.production.js 1.22 kB
dist/umd/experimental.development.js 4.81 kB
dist/umd/experimental.production.js 2.69 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.54 kB
dist/umd/react/utils.production.js 1.02 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla/utils.development.js 6.06 kB
dist/umd/vanilla/utils.production.js 3.73 kB
dist/utils.js 246 B
dist/vanilla/utils.js 5.93 kB

compressed-size-action

@dai-shi dai-shi changed the title add test for #2565 fix(vanilla): fix store.ts for an edge case May 24, 2024
@dai-shi dai-shi marked this pull request as ready for review May 24, 2024 08:39
@dai-shi dai-shi added this to the v2.8.2 milestone May 24, 2024
@dai-shi dai-shi merged commit b74cd46 into main May 27, 2024
36 checks passed
@dai-shi dai-shi deleted the bug-2565 branch May 27, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant