Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2581: subscribe method of createJSONStorage should only run in the client #2584

Conversation

mhsattarian
Copy link
Contributor

Related Issues or Discussions

Fixes #2581

Summary

Fixes some issues created by previous PR (#2539) subscribe method of createJSONStorage should only run in the client

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 11:57am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@mhsattarian
Copy link
Contributor Author

mhsattarian commented May 29, 2024

sorry, my bad. this is the wrong branch. opening a new PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createJSONStorage: localStorage is not defined
2 participants